Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_private_dns_zone_virtual_network_link - Add support for Resolution Policy #28615

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

azurerm_private_dns_zone_virtual_network_link - Add support for Resolution Policy #28615

wants to merge 2 commits into from
+74 −0

Conversation

EppO
Copy link
Contributor

@EppO EppO commented Jan 27, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add support for the new setting resolution_policy
Supported values are: Default or NxDomainRedirect

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_private_dns_zone_virtual_network_link - support for the resolution_policy property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28087

@EppO EppO requested a review from a team as a code owner January 27, 2025 23:42
@EppO EppO force-pushed the add-vnet-link-resolutionpolicy branch from 09a579c to 92b1c46 Compare January 29, 2025 17:29
@EppO
Copy link
Contributor Author

EppO commented Jan 29, 2025

all comments addressed, thanks for the review @stephybun!

@EppO EppO requested a review from stephybun January 29, 2025 18:07
@EppO EppO mentioned this pull request Jan 29, 2025
Closed
1 task
stephybun
stephybun reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EppO all of the tests are failing with

------- Stdout: -------
=== RUN   TestAccPrivateDnsZoneVirtualNetworkLink_basic
=== PAUSE TestAccPrivateDnsZoneVirtualNetworkLink_basic
=== CONT  TestAccPrivateDnsZoneVirtualNetworkLink_basic
    testcase.go:173: Step 1/3 error: Error running apply: exit status 1
        Error: creating/updating Virtual Network Link (Subscription: "*******"
        Resource Group Name: "acctestRG-250131100554195547"
        Private Dns Zone Name: "acctestzone250131100554195547.com"
        Virtual Network Link Name: "acctestVnetZone250131100554195547.com"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with response: {"code":"BadRequest","message":"The ResolutionPolicy property is applicable exclusively to private link zones."}
          with azurerm_private_dns_zone_virtual_network_link.test,
          on terraform_plugin_test.tf line 57, in resource "azurerm_private_dns_zone_virtual_network_link" "test":
          57: resource "azurerm_private_dns_zone_virtual_network_link" "test" {
--- FAIL: TestAccPrivateDnsZoneVirtualNetworkLink_basic (130.76s)
FAIL

@EppO
Copy link
Contributor Author

EppO commented Jan 31, 2025 •
edited
Loading

@EppO all of the tests are failing with

------- Stdout: -------
=== RUN   TestAccPrivateDnsZoneVirtualNetworkLink_basic
=== PAUSE TestAccPrivateDnsZoneVirtualNetworkLink_basic
=== CONT  TestAccPrivateDnsZoneVirtualNetworkLink_basic
    testcase.go:173: Step 1/3 error: Error running apply: exit status 1
        Error: creating/updating Virtual Network Link (Subscription: "*******"
        Resource Group Name: "acctestRG-250131100554195547"
        Private Dns Zone Name: "acctestzone250131100554195547.com"
        Virtual Network Link Name: "acctestVnetZone250131100554195547.com"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with response: {"code":"BadRequest","message":"The ResolutionPolicy property is applicable exclusively to private link zones."}
          with azurerm_private_dns_zone_virtual_network_link.test,
          on terraform_plugin_test.tf line 57, in resource "azurerm_private_dns_zone_virtual_network_link" "test":
          57: resource "azurerm_private_dns_zone_virtual_network_link" "test" {
--- FAIL: TestAccPrivateDnsZoneVirtualNetworkLink_basic (130.76s)
FAIL

I figured out what's wrong. This policy is only available for Private DNS zones associated to Private Link resources. In the current test, the private DNS zone is a random one acctestVnetZone%d.com. So, I guess, I need to create another example of a private dns zone of a storage account (privatelink.blob.core.windows.ne), a KV (privatelink.vaultcore.azure.net) or an ACR (privatelink.azurecr.io). Is this ok to make some tests create "fixed" resources? Who's responsible to clean them up after the test?
Can we also add a check at the provider level to prevent the user to add this setting if the Private DNS zone is not associated to a Private Link resource?

@github-actions github-actions bot added size/M and removed size/XS labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation enhancement service/dns size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for resolutionPolicy on azurerm_private_dns_zone_virtual_network_link
2 participants
@EppO @stephybun